'.c' files should now include the header that defines their functions

firmware/keyboard/ergodox/controller.c

@@ -10,9 +10,9 @@
 
 #include <stdbool.h>
 #include <stdint.h>
-#include "../../../firmware/keyboard.h"
 #include "./controller/mcp23018.h"
 #include "./controller/teensy-2-0.h"
+#include "../../keyboard.h"
 
 // ----------------------------------------------------------------------------
 

firmware/keyboard/ergodox/controller/mcp23018.c

@@ -15,6 +15,7 @@
 #include <util/twi.h>
 #include "../../../../firmware/keyboard.h"
 #include "../../../../firmware/lib/twi.h"
+#include "./mcp23018.h"
 
 // ----------------------------------------------------------------------------
 

firmware/keyboard/ergodox/controller/teensy-2-0.c

@@ -16,6 +16,7 @@
 #include <util/delay.h>
 #include "../../../../firmware/keyboard.h"
 #include "../../../../firmware/lib/twi.h"
+#include "./teensy-2-0.h"
 
 // ----------------------------------------------------------------------------
 

firmware/keyboard/ergodox/led.c

@@ -14,6 +14,7 @@
 #include <stdint.h>
 #include <avr/io.h>
 #include <util/delay.h>
+#include "../../keyboard.h"
 
 // ----------------------------------------------------------------------------
 

firmware/lib/layout/eeprom-macro/atmega32u4.c

@@ -25,7 +25,7 @@
 #include <avr/eeprom.h>
 #include "../../../../firmware/keyboard.h"
 #include "../../../../firmware/lib/eeprom.h"
-#include "../eeprom-macro.h"  // TODO: add includes like this to all implementation files
+#include "../eeprom-macro.h"
 
 // ----------------------------------------------------------------------------
 

firmware/lib/layout/key-functions/basic.c

@@ -13,6 +13,7 @@
 #include <stdint.h>
 #include "../../../../firmware/lib/usb.h"
 #include "../../../../firmware/lib/usb/usage-page/keyboard.h"
+#include "../key-functions.h"
 
 // ----------------------------------------------------------------------------
 

firmware/lib/layout/key-functions/device/atmega32u4.c

@@ -13,12 +13,13 @@
 #include <stdint.h>
 #include <avr/interrupt.h>
 #include <util/delay.h>
+#include "../../key-functions.h"
 
 // ----------------------------------------------------------------------------
 
 // from PJRC (slightly modified)
 // <http://www.pjrc.com/teensy/jump_to_bootloader.html>
-void key_functions__jump_to_bootloader (uint16_t ignore) {
+void key_functions__jump_to_bootloader(void) {
     // --- for all Teensy boards ---
 
     cli();

firmware/lib/timer/device/atmega32u4.c

@@ -17,6 +17,7 @@
 #include <avr/io.h>
 #include "../../../../firmware/lib/data-types/list.h"
 #include "../event-list.h"
+#include "../../timer.h"
 
 // ----------------------------------------------------------------------------
 

firmware/lib/timer/event-list.c

@@ -12,6 +12,7 @@
 #include <stdint.h>
 #include <stdlib.h>
 #include "../../../firmware/lib/data-types/list.h"
+#include "./event-list.h"
 
 // ----------------------------------------------------------------------------
 

firmware/lib/timer/general.c

@@ -13,6 +13,7 @@
 #include <stdint.h>
 #include "../../../firmware/lib/data-types/list.h"
 #include "./event-list.h"
+#include "../timer.h"
 
 // ----------------------------------------------------------------------------
 

firmware/lib/twi/atmega32u4.c

@@ -24,6 +24,7 @@
 
 
 #include <util/twi.h>
+#include "../twi.h"
 
 // ----------------------------------------------------------------------------
 

firmware/lib/usb/atmega32u4/general.c

@@ -12,6 +12,7 @@
 
 #include <stdbool.h>
 #include "./keyboard/from-pjrc/usb_keyboard.h"
+#include "../../usb.h"
 
 // ----------------------------------------------------------------------------
 

firmware/lib/usb/atmega32u4/keyboard.c

@@ -12,6 +12,7 @@
 #include <stdint.h>
 #include "../usage-page/keyboard.h"
 #include "./keyboard/from-pjrc/usb_keyboard.h"
+#include "../../usb.h"
 
 // ----------------------------------------------------------------------------
 

firmware/readme.md

@@ -14,6 +14,9 @@
 - add a note in the docs somewhere that SDA and SCL need to have a pull-up
   resistor on them, or `mcp23018__init()` will hang (or something like that)
 
+- add notes to directories, explaining why things are organized the way they
+  are; specifically, why the directory structure is so deep
+
 ## Dependencies
 - the gnu avr toolchain
 - python 3